Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: nitro server cors support with cookie #5549

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented Feb 17, 2025

Description

  • 修复nitro server在使用cookie时的跨域配置

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features
    • Enhanced cross-origin resource sharing support by dynamically setting the allowed origin based on the request.
    • Refined the list of permitted headers for cross-origin requests, resulting in improved security and request handling.

* 修复nitro server在使用cookie时的跨域配置
@mynetfan mynetfan requested review from anncwb, vince292007 and a team as code owners February 17, 2025 07:08
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: 947ab91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 17, 2025

Walkthrough

This pull request introduces enhancements to CORS handling in the backend. In the middleware, a new logic dynamically sets the Access-Control-Allow-Origin header based on the incoming request’s Origin header, defaulting to a wildcard (*) if no origin is provided, while preserving the existing OPTIONS request behavior. The configuration file is updated to replace a wildcard for Access-Control-Allow-Headers with a specific, explicit list of allowed headers.

Changes

File(s) Change Summary
apps/.../middleware/1.api.ts Added logic to dynamically set Access-Control-Allow-Origin in responses based on the request's Origin header or a fallback to *, with OPTIONS handling unchanged.
apps/.../nitro.config.ts Replaced the wildcard in Access-Control-Allow-Headers with an explicit list of allowed headers for API routeRules.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Middleware
    Client->>Middleware: Send request (with/without Origin)
    alt Origin header is present
        Middleware->>Middleware: Set Access-Control-Allow-Origin to request's Origin
    else
        Middleware->>Middleware: Set Access-Control-Allow-Origin to "*"
    end
    alt Request method is OPTIONS
        Middleware->>Client: Return 204 OK
    else
        Middleware->>Client: Return response with appropriate CORS header
    end
Loading

Suggested labels

chore

Suggested reviewers

  • anncwb
  • vince292007

Poem

I hopped through the code fields bright and fair,
Adjusting headers with delicate care.
My little paws set CORS just right,
Letting OPTIONS dance into the night.
Celebrate with a bunny leap, so light! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
apps/backend-mock/nitro.config.ts (1)

8-18: Consider adding rate limiting for security.

Since this is an API endpoint with CORS and cookie support, consider adding rate limiting to prevent abuse.

You can use the built-in H3 rate limiting middleware. Here's an example configuration:

  '/api/**': {
    cors: true,
+   rateLimit: {
+     windowMs: 15 * 60 * 1000, // 15 minutes
+     max: 100 // limit each IP to 100 requests per windowMs
+   },
    headers: {
      // ... existing headers
    },
  },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6b97ac and 947ab91.

📒 Files selected for processing (2)
  • apps/backend-mock/middleware/1.api.ts (1 hunks)
  • apps/backend-mock/nitro.config.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)
  • GitHub Check: Lint (ubuntu-latest)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Check (ubuntu-latest)

@mynetfan mynetfan merged commit e0eb57d into vbenjs:main Feb 17, 2025
14 checks passed
@mynetfan mynetfan deleted the mock/update branch February 17, 2025 07:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant