-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: nitro server cors support with cookie #5549
Conversation
* 修复nitro server在使用cookie时的跨域配置
|
WalkthroughThis pull request introduces enhancements to CORS handling in the backend. In the middleware, a new logic dynamically sets the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Middleware
Client->>Middleware: Send request (with/without Origin)
alt Origin header is present
Middleware->>Middleware: Set Access-Control-Allow-Origin to request's Origin
else
Middleware->>Middleware: Set Access-Control-Allow-Origin to "*"
end
alt Request method is OPTIONS
Middleware->>Client: Return 204 OK
else
Middleware->>Client: Return response with appropriate CORS header
end
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/backend-mock/nitro.config.ts (1)
8-18
: Consider adding rate limiting for security.Since this is an API endpoint with CORS and cookie support, consider adding rate limiting to prevent abuse.
You can use the built-in H3 rate limiting middleware. Here's an example configuration:
'/api/**': { cors: true, + rateLimit: { + windowMs: 15 * 60 * 1000, // 15 minutes + max: 100 // limit each IP to 100 requests per windowMs + }, headers: { // ... existing headers }, },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/backend-mock/middleware/1.api.ts
(1 hunks)apps/backend-mock/nitro.config.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Test (windows-latest)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Check (ubuntu-latest)
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit