Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Increase test coverage #12

Closed
21 tasks done
vdjagilev opened this issue Jul 4, 2021 · 0 comments · Fixed by #24
Closed
21 tasks done

Increase test coverage #12

vdjagilev opened this issue Jul 4, 2021 · 0 comments · Fixed by #24
Assignees
@vdjagilev
Labels
priority/medium Medium priority issue tech/go Golang type/feature New feature (or request)
Milestone
Version 0.1.0

Comments

@vdjagilev
Copy link
Owner

vdjagilev commented Jul 4, 2021 •
edited
Loading

Those parts needs to be covered with tests:

  • Formatter package
    • Workflow
    • HTML
      • check if HTML is valid (parse without error)
      • validate if all parts exist in HTML
        • hosts
        • ports
      • check --skip* output options
    • Markdown
      • parses without error
      • hosts
      • ports
    • JSON
    • CSV
      • Check if hosts that are down skipped by default
      • Check with --skip-down-hosts=false if down hosts are not skipped
  • cmd
    • arguments check
    • run
    • validation
  • Fix github actions workflow (run all tests via: go test ./... -count=1 -v)
@vdjagilev vdjagilev added priority/medium Medium priority issue tech/go Golang type/feature New feature (or request) labels Jul 4, 2021
@vdjagilev vdjagilev self-assigned this Jul 4, 2021
@vdjagilev vdjagilev added this to the Version 0.1.0 milestone Jul 4, 2021
vdjagilev added a commit that referenced this issue Jul 8, 2021
@vdjagilev
#12: Add cmd/ tests & refactor code (#22)
d921640 
* Make rootCmd functions separate. Use RunE instead of Run

* Add workflow interface for easier testing

* Add cmd/root unit tests
vdjagilev added a commit that referenced this issue Jul 8, 2021
@vdjagilev
#12: Add prettier to avoid tabs in YML
4ce1cc9
vdjagilev added a commit that referenced this issue Jul 8, 2021
@vdjagilev
#12: Run unit tests for all packages
d0eed4e
@vdjagilev vdjagilev mentioned this issue Jul 8, 2021
Merged
vdjagilev added a commit that referenced this issue Jul 11, 2021
@vdjagilev
#12: Add CSV formatter test cases
fd8cc3e
vdjagilev added a commit that referenced this issue Jul 11, 2021
@vdjagilev
#12: Add CSV formatter test cases
4394347
vdjagilev added a commit that referenced this issue Jul 11, 2021
@vdjagilev
#12: Add codecov
81aa91d
vdjagilev added a commit that referenced this issue Jul 11, 2021
@vdjagilev
#12: Add CSV formatter Format() tests
0e71003
vdjagilev added a commit that referenced this issue Jul 11, 2021
@vdjagilev
#12: Add JSON formatter tests
0b114a0
vdjagilev added a commit that referenced this issue Jul 14, 2021
@vdjagilev
#12: Move workflow interface/struct to separate file
9bb9103
@vdjagilev vdjagilev linked a pull request Jul 14, 2021 that will close this issue
#12: Increase unit test coverage #24
Merged
vdjagilev added a commit that referenced this issue Jul 14, 2021
@vdjagilev
#12: Add workflow unit-tests
1f274b5
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Add HTML Formatter tests
35ccf48
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Refactor formatter_md and remove warnings
8f4f40c
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Add more tests for Markdown formatter
b2c2ad1
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Add remaining formatter.go tests
4a5c1ce
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Add codecov badge
86ab3b0
vdjagilev added a commit that referenced this issue Jul 18, 2021
@vdjagilev
#12: Increase unit test coverage (#24)
20ee30b 
* #12: Add cmd/ tests & refactor code (#22)

* Make rootCmd functions separate. Use RunE instead of Run

* Add workflow interface for easier testing

* Add cmd/root unit tests

* #12: Add prettier to avoid tabs in YML

* #12: Run unit tests for all packages

* #12: Add CSV formatter test cases

* #12: Add codecov

* #12: Add CSV formatter Format() tests

* #12: Add JSON formatter tests

* #12: Move workflow interface/struct to separate file

* #12: Add workflow unit-tests

* #12: Add HTML Formatter tests

* #12: Refactor formatter_md and remove warnings

* #12: Add more tests for Markdown formatter

* #12: Add remaining formatter.go tests

* #12: Add codecov badge
@vdjagilev vdjagilev mentioned this issue Jul 18, 2021
Closed
vdjagilev added a commit that referenced this issue Jul 19, 2021
@vdjagilev
#12: Increase unit test coverage (#24)
f79e2d1 
* #12: Add cmd/ tests & refactor code (#22)

* Make rootCmd functions separate. Use RunE instead of Run

* Add workflow interface for easier testing

* Add cmd/root unit tests

* #12: Add prettier to avoid tabs in YML

* #12: Run unit tests for all packages

* #12: Add CSV formatter test cases

* #12: Add codecov

* #12: Add CSV formatter Format() tests

* #12: Add JSON formatter tests

* #12: Move workflow interface/struct to separate file

* #12: Add workflow unit-tests

* #12: Add HTML Formatter tests

* #12: Refactor formatter_md and remove warnings

* #12: Add more tests for Markdown formatter

* #12: Add remaining formatter.go tests

* #12: Add codecov badge
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vdjagilev vdjagilev

Labels
priority/medium Medium priority issue tech/go Golang type/feature New feature (or request)
Projects
None yet
Milestone
Version 0.1.0
Development

Successfully merging a pull request may close this issue.

#12: Increase unit test coverage vdjagilev/nmap-formatter
1 participant
@vdjagilev