Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid plural duplicates in nmap struct #78

Closed
vdjagilev opened this issue Apr 22, 2022 · 0 comments · Fixed by #93
Closed

Avoid plural duplicates in nmap struct #78

vdjagilev opened this issue Apr 22, 2022 · 0 comments · Fixed by #93
Assignees
@vdjagilev
Labels
priority/medium Medium priority issue prop/bc-break Property: Breaking Change tech/go Golang type/other An issue that do not fall under the category of a bug or a feature
Milestone
1.0.0

Comments

@vdjagilev
Copy link
Owner

Currently there is a duplicate for ports field. It should be simply Port[] instead of Ports.Port[]
@vdjagilev vdjagilev added priority/medium Medium priority issue type/other An issue that do not fall under the category of a bug or a feature tech/go Golang labels Apr 22, 2022
@vdjagilev vdjagilev added this to v3 Apr 22, 2022
@vdjagilev vdjagilev added this to the 1.0.0 milestone Apr 22, 2022
@vdjagilev vdjagilev moved this to Todo in v3 Apr 23, 2022
@vdjagilev vdjagilev moved this from Todo to In Progress in v3 Apr 28, 2022
@vdjagilev vdjagilev added the prop/bc-break Property: Breaking Change label Apr 28, 2022
vdjagilev added a commit that referenced this issue Apr 28, 2022
@vdjagilev
#78: Make struct field Ports to be singular
14bfdeb
@vdjagilev vdjagilev mentioned this issue Apr 28, 2022
Merged
@vdjagilev vdjagilev moved this from In Progress to Review in v3 Apr 28, 2022
@vdjagilev vdjagilev linked a pull request Apr 28, 2022 that will close this issue
#78: Make struct field Ports to be singular #93
Merged
vdjagilev added a commit that referenced this issue Apr 28, 2022
@vdjagilev
#78: Make struct field Ports to be singular (#93)
25a3bf2 
* #78: Make struct field Ports to be singular

* Rename table class in html template
@vdjagilev vdjagilev moved this from Review to Done in v3 Apr 28, 2022
@vdjagilev vdjagilev self-assigned this Apr 28, 2022
vdjagilev added a commit that referenced this issue May 2, 2022
@vdjagilev
#78: Make struct field Ports to be singular (#93)
0f4881d 
* #78: Make struct field Ports to be singular

* Rename table class in html template
@vdjagilev vdjagilev moved this from Done to Released in v3 May 2, 2022
Repository owner moved this from Released to Done in v3 May 2, 2022
@vdjagilev vdjagilev moved this from Done to Released in v3 May 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vdjagilev vdjagilev

Labels
priority/medium Medium priority issue prop/bc-break Property: Breaking Change tech/go Golang type/other An issue that do not fall under the category of a bug or a feature
Projects
v3
Status: Released / Merged
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

#78: Make struct field Ports to be singular vdjagilev/nmap-formatter
1 participant
@vdjagilev