Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: extracting docker image name for scan correctly #1488

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

freemanzMrojo
Copy link
Member

Description

The step to extract the Docker image name was wrong for cases when there was more than one value.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Using the SDK pipeline

Test Configuration:

  • Node.js Version: 20.18.0
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@freemanzMrojo freemanzMrojo requested a review from a team as a code owner November 7, 2024 16:37
Copy link

github-actions bot commented Nov 7, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
98.99% (4334/4378) 97.61% (1390/1424) 99% (891/900)
Title Tests Skipped Failures Errors Time
core 810 0 💤 0 ❌ 0 🔥 2m 18s ⏱️
network 726 0 💤 0 ❌ 0 🔥 4m 53s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 16.599s ⏱️
logging 3 0 💤 0 ❌ 0 🔥 18.776s ⏱️
hardhat-plugin 19 0 💤 0 ❌ 0 🔥 57.745s ⏱️
aws-kms-adapter 23 0 💤 0 ❌ 0 🔥 1m 24s ⏱️
ethers-adapter 5 0 💤 0 ❌ 0 🔥 1m 12s ⏱️
rpc-proxy 37 0 💤 0 ❌ 0 🔥 1m 5s ⏱️

@freemanzMrojo freemanzMrojo merged commit 91985f3 into main Nov 7, 2024
14 checks passed
@freemanzMrojo freemanzMrojo deleted the fix/extracting-docker-image-name-correctly branch November 7, 2024 20:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants