chore(networking): Upgrade trust-dns
#2512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Hoverbear
reviewed
May 5, 2020
Hoverbear
approved these changes
May 6, 2020
|
@LucioFranco The CI is unhappy with this PR. Otherwise it looks good :) |
|
I can't seem to reproduce any of these failures locally but they seem to be very consistent on CI :/ |
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
fanatid
reviewed
May 10, 2020
| @@ -1,7 +1,5 @@ | |||
| [advisories] | |||
| ignore = [ | |||
| "RUSTSEC-2020-0014", # Advisory for dev dependency of `trust-dns` for testing | |||
| # dns servers. | |||
| "RUSTSEC-2020-0002", # tracked in #1639 | |||
| "RUSTSEC-2020-0001", # dev dependency only | |||
There was a problem hiding this comment.
RUSTSEC-2020-0001 not required with this changes too?
https://rustsec.org/advisories/RUSTSEC-2020-0001.html
There was a problem hiding this comment.
Yup, good catch we can remove that one as well!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
trust-dnsand allows us to fix the RUSTSEC issue that came up earlier this week.Currently, blocked by https://github.com/bluejekyll/trust-dns/pull/1087 and #2511 is open to upgrade to the crates version.
Closes #2464
Signed-off-by: Lucio Franco luciofranco14@gmail.com