Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: clippy error #325

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: clippy error #325

merged 1 commit into from
Jan 6, 2025

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Jan 5, 2025

Description

Fixed empty-line-after-doc-comments error added into the default warning in Clippy 1.83.

Failed workflow log:
https://github.com/veeso/termscp/actions/runs/12526546042/job/34939229766#step:7:332

error: empty line after doc comment
   --> src/ui/activities/filetransfer/mod.rs:357:1
    |
357 | / /**
358 | |  * Activity Trait
359 | |  * Keep it clean :)
360 | |  * Use methods instead!
361 | |  */
362 | |
    | |_
363 |   impl Activity for FileTransferActivity {
    |   -------------------------------------- the comment documents this implementation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
    = help: if the empty line is unintentional remove it

error: could not compile `termscp` (bin "termscp") due to 1 previous error

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no new C-bindings
  • The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

@veeso veeso merged commit 8a9ba77 into veeso:main Jan 6, 2025
3 checks passed
@eggplants eggplants deleted the fix-clippy-error branch January 6, 2025 12:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants