Make imports of heavy packages lazy #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
commented
May 9, 2024
| @@ -82,6 +81,3 @@ def spec_to_mime_bundle( | |||
| return {"image/png": png} | |||
| else: | |||
| raise ValueError(f"Unsupported mimetype: {mimetype}") | |||
|
|
|||
|
|
|||
| alt.renderers.register('vegafusion-mime', vegafusion_mime_renderer) | |||
There was a problem hiding this comment.
Now registered using an entry point to avoid the need to import altair
jonmmease
commented
May 9, 2024
| return None | ||
| group = child_group | ||
|
|
||
| return group |
There was a problem hiding this comment.
Moved out from evaluation.py since it's not used there any more
jonmmease
commented
May 9, 2024
|
|
||
|
|
||
| alt.data_transformers.register("vegafusion-feather", feather_transformer) | ||
| alt.data_transformers.register("vegafusion-inline", inline_data_transformer) |
There was a problem hiding this comment.
Moved to entry point for registration so as to not import altair for register
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve VegaFusion import time by making the imports of the following packages lazy:
pyarrowpolarspandasduckdbaltairPreviously these would all be imported eagerly if they are installed, which could lead to multi-second import time if VegaFusion is used in an environment where they are all installed.
To make it easier to make
altairlazy, I updated thetransformed_datafunction to delegate to the Altair implementation.