Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Core Search Integration don't work #66

Closed
Scippy opened this issue Jun 25, 2021 · 10 comments
Closed

Core Search Integration don't work #66

Scippy opened this issue Jun 25, 2021 · 10 comments

Comments

@Scippy
Copy link
Contributor

Scippy commented Jun 25, 2021

I've enabled "Allow Core Search Integration?" options in Main Options, but searching with DNN core search nothing published in ventrian news articles is founded.
am I wrong something or is there a problem?

@Scippy
Copy link
Contributor Author

Scippy commented Jul 8, 2021

is anyone able to give me feedback about it?
Thanks!

@JoeAucoin
Copy link

I cannot get it to work either . . . does something need to be added to the DNN Scheduler?

@skamphuis
Copy link
Collaborator

I didn't dive into the details of this, but it looks like DNN doesn't support the old ISearchable interface anymore, which was used by NewsArticles. If that's true, that basically means DNN isn't asking NA for it's content anymore, to use for the core search.

@Scippy
Copy link
Contributor Author

Scippy commented Dec 6, 2021

Any chance to make it work again?

@skamphuis
Copy link
Collaborator

If I'm not mistaken, the ISearchable interface News Articles is using for DNN search integration, is not supported anymore (and hasn't been supported for a while already). Not sure if anyone else has, but I don't have any plans to change that, sorry.

@Scippy
Copy link
Contributor Author

Scippy commented Dec 7, 2021

@skamphuis thank you for your reply but What's the reason? Maybe it takes too long time to fix?

@skamphuis
Copy link
Collaborator

@skamphuis thank you for your reply but What's the reason? Maybe it takes too long time to fix?

Well, I guess it should be done in under 4 hours or something like that. But it's not a fun thing to make and I believe people would be better of by using that time to implement another solution that will support DNN Core Search integration. We use OpenContent for example.

@Scippy
Copy link
Contributor Author

Scippy commented Dec 7, 2021

@skamphuis Do you mean then that you will no longer support this module and that we should stop using it?

@skamphuis
Copy link
Collaborator

I think everyone should have stopped using it several years ago, but of course it's not always that easy. We were happy to be able to do some mainenance occasionally, together with several other contributors. That way there where options when there as a need in situations where migration to another module was not, or not yet, an option for various reasons. As it says in the readme file:

We are mainly fixing issues for our clients, so don't expect 40F to fix all issues. Pull request are always welcome. :-)
We are currently in the process of converting our clients News Articles modules to Open Content and will stop using and supporting this module in the near future."

Hope this explains things a bit?

@skamphuis
Copy link
Collaborator

By the way, @Timo-Breumelhof and I are looking into fixing one more release soon, with a few pull requests that have not been incorporated yet, "to wrap things up".

skamphuis added a commit that referenced this issue Feb 2, 2022
skamphuis pushed a commit to 40fingers/News-Articles that referenced this issue Feb 2, 2022
Integration with DNN core search ModuleSearchBase
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants