Removed restriction for folder name 'app' inside the source code under test. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sa-ny
commented
Oct 14, 2024
•
sa-ny
commented
- BatchFix and SingleFix now each have their own separate list of supported CWEs.
- The process for creating the source code tar file and flaw.json for BatchFix has been moved out of the source code folder to temp folder.
sa-ny
changed the title
julz0815
approved these changes
Oct 23, 2024
| @@ -0,0 +1,28 @@ | |||
| export const sourcecodeFolderName = 'app/'; | |||
| //export temp folder value from github action | |||
| export const tempFolder = process.env.RUNNER_TEMP ? (process.env.RUNNER_TEMP + '/') : ''; | |||
There was a problem hiding this comment.
Are we sure the tempfolder is writeable in all runner images a customer may use? I would not make this hardcoded to temp, maybe as a default, but have it configurable maybe?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.