Modify how errors in the execution engine are handled. #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In execution_engine_manager.rs, dispatch_on_incoming_data now returns response_invalid_request when there was an error. In server_test.rs, test_template now distinguishes between an error and an event not returning SUCCESS. There is an additional argument, expect_success.
ShaleXIONG
approved these changes
Jan 13, 2023
mathias-arm
added
trusted-veracruz-runtime
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
execution_engine_manager.rs,dispatch_on_incoming_datanow returnsresponse_invalid_requestwhen there was an error.In
server_test.rs,test_templatenow distinguishes between an error and an event not returningSUCCESS. There is an additional argument,expect_success.