Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed match regex to support negative numbers #96

Merged
merged 9 commits into from
Nov 29, 2017
Merged

Fixed match regex to support negative numbers #96

merged 9 commits into from
Nov 29, 2017

Conversation

yoavmmn
Copy link
Contributor

@yoavmmn yoavmmn commented Sep 13, 2017

WHATSUP

The match regex was missing support for negative numbers. issue #70

Before

ms(ms(-10)) // undefined

returns undefined.
It seems natural to get a response like -10 if ms(-10) returns -10ms.

After

ms(ms(-10)) // -10
ms(ms(-.10)) // -0.10
ms(ms(-0.10)) // -0.10

Returns the appropriate result. it doesn't affect any other test and work with floats.

@TooTallNate TooTallNate merged commit f0bc0a2 into vercel:master Nov 29, 2017
@TooTallNate
Copy link
Member

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants