Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce asset emission and handle unexpected core assets #166

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

guybedford
Copy link
Contributor

I just noticed the core build was giving the assets emitted error.

This was because:

  • The directory emission was resulting in a lot of new ".js" assets being emitted (eg the whole of webpack/lib was being emitted as an asset), when these wouldn't be supported in those workflows, so instead disabled ".js" emission for directory assets. This should reduce build sizes nicely.
  • The directory emission is actually correctly handling the TypeScript declaration files that we have a custom copy for, which was nice to see
  • There are some locales being emitted by one of the core dependencies, that we don't use, so I'm just filtering this out.

@guybedford
Copy link
Contributor Author

I've disabled the loopback test for now as the middleware is broken as in #141, this PR just makes that error happen earlier.

@codecov-io
Copy link

Codecov Report

Merging #166 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #166     +/-   ##
=========================================
- Coverage   77.49%   77.29%   -0.2%     
=========================================
  Files          11       11             
  Lines         511      511             
=========================================
- Hits          396      395      -1     
- Misses        115      116      +1
Impacted Files Coverage Δ
src/loaders/relocate-loader.js 92.77% <100%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ab392...d3be145. Read the comment docs.

@rauchg rauchg merged commit b83e921 into master Dec 17, 2018
@rauchg rauchg deleted the asset-reductions branch December 17, 2018 20:03
rauchg added a commit that referenced this pull request Dec 17, 2018
rauchg added a commit that referenced this pull request Dec 17, 2018
* Revert "fix minify default (#168)"

This reverts commit c289b28.

* Revert "Reduce asset emission and handle unexpected core assets (#166)"

This reverts commit b83e921.

* Revert "use graceful-fs (#167)"

This reverts commit 4ab1f82.

* Revert "fix ignore"

This reverts commit e6ab392.

* Revert "add typescript config for test"

This reverts commit fa95d0b.

* Revert "0.6.0"

This reverts commit 2f12e50.

* Revert "add typescript test"

This reverts commit d4d0ead.

* Revert "Add support for tsconfig `paths`. (fixes #150) (#151)"

This reverts commit 4c227fb.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants