-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Disable ts caching for typechecking #213
Conversation
(Note caching still applies fine to everything in node_modules of course) |
b1aa7ca
to
4a84a7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 68.68% 68.84% +0.15%
==========================================
Files 12 13 +1
Lines 594 597 +3
==========================================
+ Hits 408 411 +3
Misses 186 186
Continue to review full report at Codecov.
|
Hey @guybedford!
I'm afraid I'm not too close to this issue; got a lot going on right now. From your comment am I right in understanding that you think that making the changes suggested on #208 seem unwise? Also, are you aware of https://github.com/Realytics/fork-ts-checker-webpack-plugin This plugin works nicely in concert with |
Thanks for the update @johnnyreilly. Our use case for the webpack cache is having the TS internal cache persisted between runs, which I don't think either project would offer us currently? Work towards that is what I was referring to in my comment. Running the separate projects with threading definitely seems like it would be a worthwhile perf improvement though only for the cold build times (and watcher I suppose). |
Totally correct yes
Yes you should definitely see a gain in those scenarios. Thanks for giving me a heads up BTW; had no idea ts-loader was being used in NCC 😁 |
This is the alternative fix to #210 that retains the typing errors being emitted.
The approach here is to disable caching for ts compilations entirely to ensure that the types of the local files are checked everytime.
To utilize the webpack 5 cache for this work would likely require the ts-loader project to serialize its internal memoizations using the webpack cache api while itself becoming uncacheable. //cc @johnnyreilly