Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chromeless fix (#192) #221

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Chromeless fix (#192) #221

merged 1 commit into from
Jan 15, 2019

Conversation

guybedford
Copy link
Contributor

This fixes the Chromeless build using a very simple boolean inlining approach.

We have to be quite careful with this not to inline the wrong booleans (say there was a process.env check that evaluates to false in the build but will evaluate to true in production). So this is just restricted to the specific trigger cases around assets.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #221 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #221     +/-   ##
=======================================
+ Coverage   69.59%    70%   +0.4%     
=======================================
  Files          13     13             
  Lines         661    670      +9     
=======================================
+ Hits          460    469      +9     
  Misses        201    201
Impacted Files Coverage Δ
src/loaders/relocate-loader.js 92.92% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962d867...3b2be82. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants