Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Asset relocator refactoring #234

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Asset relocator refactoring #234

merged 2 commits into from
Jan 18, 2019

Conversation

guybedford
Copy link
Contributor

This implements the refactoring described in #223.

Binding analysis is now fully general with no specific import / require / binding cases.

It's a pretty major refactoring, but seems to have worked out well in the end luckily!

@guybedford
Copy link
Contributor Author

(this is based to #232 so should be merged after #233).

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@208cdc0). Click here to learn what that means.
The diff coverage is 91.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage          ?   69.86%           
=========================================
  Files             ?       16           
  Lines             ?      657           
  Branches          ?        0           
=========================================
  Hits              ?      459           
  Misses            ?      198           
  Partials          ?        0
Impacted Files Coverage Δ
src/utils/binary-locators.js 83.78% <83.78%> (ø)
src/loaders/relocate-loader.js 97.07% <93.1%> (ø)
src/utils/wrappers.js 93.93% <93.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208cdc0...543f96f. Read the comment docs.

@rauchg rauchg merged commit e94a2d8 into master Jan 18, 2019
@rauchg rauchg deleted the relocate-refactor branch January 18, 2019 21:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants