Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixup TypeScript build, and sourcemap filename bug #244

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

guybedford
Copy link
Contributor

This fixes #237, adding a console log of the TypeScript version being used in the build:

ncc: Using typescript@3.2.2 (ncc built-in)
# or
ncc: Using typescript@3.2.2 (local user-provided)

It also resolves the bug in master with the error Error: ENOENT: no such file or directory, open '/usr/local/lib/node_modules/@zeit/ncc/dist/ncc/source-register.js.cache.js' due to a file name typo.

@codecov-io
Copy link

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          16       16           
  Lines         670      670           
=======================================
  Hits          464      464           
  Misses        206      206
Impacted Files Coverage Δ
src/loaders/ts-loader.js 88.88% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2915a8e...c23ac06. Read the comment docs.

@rauchg rauchg merged commit a63a5e6 into master Jan 28, 2019
@rauchg rauchg deleted the ts-sourcemaps-fixes branch January 28, 2019 23:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ncc@0.11.0 typescript error
3 participants