Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Local TS integration test #252

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Local TS integration test #252

merged 1 commit into from
Jan 31, 2019

Conversation

guybedford
Copy link
Contributor

This follows #251 and adds a full test for the local TypeScript version lookup.

@codecov-io
Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #252 into master will increase coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   74.25%   74.26%   +<.01%     
==========================================
  Files          17       17              
  Lines         874      882       +8     
==========================================
+ Hits          649      655       +6     
- Misses        225      227       +2
Impacted Files Coverage Δ
src/typescript.js 77.77% <77.77%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888e86f...e19bb2f. Read the comment docs.

@rauchg
Copy link
Member

rauchg commented Jan 30, 2019

Needs rebase

@guybedford guybedford force-pushed the local-ts-integration-test branch from 7a0116d to a1026bb Compare January 30, 2019 21:48
@guybedford guybedford force-pushed the local-ts-integration-test branch from a1026bb to e19bb2f Compare January 30, 2019 21:51
@rauchg rauchg merged commit e121cd4 into master Jan 31, 2019
@rauchg rauchg deleted the local-ts-integration-test branch January 31, 2019 05:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid

@ghost
Copy link

ghost commented Jan 31, 2021

Invalid

@ghost
Copy link

ghost commented Jan 31, 2021

@kingabnt

@huozhi huozhi mentioned this pull request Mar 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants