Fix NEXT_PUBLIC env values not being inlined (#11896)

* Clean up env tests a bit * Fix NEXT_PUBLIC env values not being inlined Co-authored-by: Joe Haddad <joe.haddad@zeit.co>
vercel · Apr 15, 2020 · 2b488ab · 2b488ab
1 parent 6202a7f
commit 2b488ab
Show file tree

Hide file tree

Showing 4 changed files with 105 additions and 397 deletions.
diff --git a/packages/next/build/webpack-config.ts b/packages/next/build/webpack-config.ts
@@ -769,7 +769,7 @@ export default async function getBaseWebpackConfig(
           ? Object.keys(process.env).reduce(
               (prev: { [key: string]: string }, key: string) => {
                 if (key.startsWith('NEXT_PUBLIC_')) {
-                  prev[key] = process.env[key]!
+                  prev[`process.env.${key}`] = JSON.stringify(process.env[key]!)
                 }
                 return prev
               },

diff --git a/test/integration/env-config/app/next.config.js b/test/integration/env-config/app/next.config.js
@@ -0,0 +1,15 @@
+module.exports = {
+  experimental: {
+    pageEnv: true,
+
+    async redirects() {
+      return [
+        {
+          source: '/hello',
+          permanent: false,
+          destination: `/${process.env.NEXT_PUBLIC_TEST_DEST}`,
+        },
+      ]
+    },
+  },
+}
diff --git a/test/integration/env-config/app/pages/next-config-loaded-env.js b/test/integration/env-config/app/pages/next-config-loaded-env.js