Skip to content

Commit

Permalink
Revert "[Turbopack] fix effects tracing (#72928)"
Browse files Browse the repository at this point in the history
This reverts commit 0714c45.
  • Loading branch information
sokra committed Nov 27, 2024
1 parent 6169338 commit 59a27ce
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions turbopack/crates/turbo-tasks/src/effect.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,12 @@ impl Eq for Effects {}
impl Effects {
/// Applies all effects that have been captured by this struct.
pub async fn apply(&self) -> Result<()> {
let span = tracing::info_span!("apply effects", count = self.effects.len());
async move {
let mut first_error = anyhow::Ok(());
for effect in self.effects.iter() {
apply_effect(effect, &mut first_error).await;
}
first_error
let _span = tracing::info_span!("apply effects", count = self.effects.len());
let mut first_error = anyhow::Ok(());
for effect in self.effects.iter() {
apply_effect(effect, &mut first_error).await;
}
.instrument(span)
.await
first_error
}
}

Expand Down

0 comments on commit 59a27ce

Please # to comment.