Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ensure module not found error is shown with jsconfig paths #11889

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Ensure module not found error is shown with jsconfig paths #11889

merged 3 commits into from
Apr 15, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 14, 2020 •
edited
Loading

This fixes an empty module not found error being shown when failing to resolve a path from jsconfig or tsconfig. The error is empty here since we were throwing an error from the plugin which isn't handled by webpack so this removes it in favor of webpack's handling. It also seems we can't cleanly log from there or else the log will be repeated multiple times since multiple resolutions are occurring

Before before
After after

@ijjk ijjk added this to the 9.3.5 milestone Apr 14, 2020
@ijjk
Copy link
Member Author

ijjk commented Apr 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 11.3s 11.2s -86ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.231 2.405 ⚠️ +0.17
/ avg req/sec 1120.46 1039.47 -80.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.255 1.299 ⚠️ +0.04
/error-in-render avg req/sec 1991.37 1925.1 -66.27
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..f272.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
index.html gzip 930 B 930 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 12s 12.1s ⚠️ +40ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..f272.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member Author

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 10.4s 10.5s ⚠️ +102ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.083 2.147 ⚠️ +0.06
/ avg req/sec 1200.12 1164.62 -35.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.185 1.233 ⚠️ +0.05
/error-in-render avg req/sec 2110.5 2027.02 -83.48
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
index.html gzip 925 B 925 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 11.2s 11.1s -54ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member Author

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 11s 11.3s ⚠️ +275ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.195 2.286 ⚠️ +0.09
/ avg req/sec 1139.06 1093.76 -45.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.289 1.32 ⚠️ +0.03
/error-in-render avg req/sec 1939.58 1893.8 -45.78
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
buildDuration 12.2s 12s -184ms
nodeModulesSize 55.5 MB 55.5 MB -204 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/NEXT-169-jsconfig-resolve-error Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@Timer Timer modified the milestones: 9.3.5, 9.3.6 Apr 15, 2020
Timer
Timer approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hbu @timneutkens?

@Timer Timer changed the title Ensure correct module not found error is shown with jsconfig paths Ensure module not found error is shown with jsconfig paths Apr 15, 2020
@Timer Timer merged commit 2b116ce into vercel:canary Apr 15, 2020
@Timer Timer deleted the add/NEXT-169-jsconfig-resolve-error branch April 15, 2020 06:33
@Timer
Copy link
Member

Timer commented Apr 15, 2020 •
edited
Loading

Landing as it's more correct than current behavior (unactionable error). @timneutkens feel free to critique implementation since you did this impl.

@timneutkens
Copy link
Member

Looks good, one of the main reasons I added that throw is to show the list of tried paths, as you can alias a scope to multiple paths and it's hard to debug if you configured it correctly otherwise.

This was referenced May 1, 2020
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @Timer @timneutkens