Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Allow reading request bodies in middlewares" #34479

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 17, 2022

This temporarily reverts this change to allow more time for testing without blocking release.

Reverts #34294

@ijjk
Copy link
Member Author

ijjk commented Feb 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
buildDuration 15.3s 15.3s ⚠️ +23ms
buildDurationCached 6s 6s ⚠️ +41ms
nodeModulesSize 359 MB 359 MB -6.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
/ failed reqs 0 0
/ total time (seconds) 3.075 3.014 -0.06
/ avg req/sec 812.99 829.37 +16.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.191 1.202 ⚠️ +0.01
/error-in-render avg req/sec 2098.6 2080.64 ⚠️ -17.96
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
buildDuration 18.9s 18.7s -162ms
buildDurationCached 6s 5.9s -97ms
nodeModulesSize 359 MB 359 MB -6.07 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
/ failed reqs 0 0
/ total time (seconds) 2.989 3.003 ⚠️ +0.01
/ avg req/sec 836.48 832.53 ⚠️ -3.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.174 1.159 -0.01
/error-in-render avg req/sec 2129.83 2156.67 +26.84
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34294-read-json-body Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 2db9355

@ijjk

This comment was marked as outdated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants