-
Notifications
You must be signed in to change notification settings - Fork 28.3k
Fix for #204 #401
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix for #204 #401
Conversation
React addons require React in a special way. That causes Webpack to push React into the app's bundle. This fix adds new externals entries to prevent that.
1 similar comment
Beautiful. Yet, pretty strange that react addons require react like that? What's the rationale? |
Not exactly sure. But that might be the case that, FB uses their own module resolver for React. |
@gaearon what's the rational behind the |
May be related. See: facebook/react#6343 |
It's just importing |
Thanks @gaearon |
@arunoda Are you sure that this fix is correct?
I am not a JS expert, so I am not exactly sure, but it feels like this patch will just break the addons. |
Fixes #204
React addons require React in a special way.
That causes Webpack to push React into the app's bundle.
This fix adds new externals entries to prevent that.