Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CSS resource path not matched in __entry_css_files__ #44310

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Dec 23, 2022

Currently we use this.appDir + entryName as the key of app entries. The appDir part is an absolute path which contains \ in Windows, but entryName is a general entry name for Webpack, like app/page. A quick fix is to replace all / in the entry name with the current system separator.

Confirmed that it fixed the problem in Windows.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@kodiakhq kodiakhq bot merged commit 00b2113 into canary Dec 23, 2022
@ijjk
Copy link
Member

ijjk commented Dec 23, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js shu/d9uz Change
buildDuration 37.1s 37.1s -12ms
buildDurationCached 10.6s 10.6s -43ms
nodeModulesSize 95 MB 95 MB
nextStartRea..uration (ms) 286ms 282ms -4ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/d9uz Change
152-HASH.js gzip 64.5 kB 64.5 kB
53.HASH.js gzip 182 B 182 B
main-app-HASH.js gzip 205 B 205 B
main-HASH.js gzip 79.2 kB 79.2 kB
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 146 kB 146 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/d9uz Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js shu/d9uz Change
_app-HASH.js gzip 192 B 192 B
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 484 B 484 B
css-HASH.js gzip 804 B 804 B
dynamic-HASH.js gzip 2.29 kB 2.29 kB
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 827 B 827 B
hooks-HASH.js gzip 848 B 848 B
image-HASH.js gzip 4.3 kB 4.3 kB
index-HASH.js gzip 252 B 252 B
link-HASH.js gzip 2.69 kB 2.69 kB
routerDirect..HASH.js gzip 782 B 782 B
script-HASH.js gzip 857 B 857 B
withRouter-HASH.js gzip 781 B 781 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.6 kB 15.6 kB
Client Build Manifests
vercel/next.js canary vercel/next.js shu/d9uz Change
_buildManifest.js gzip 481 B 481 B
Overall change 481 B 481 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/d9uz Change
index.html gzip 490 B 490 B
link.html gzip 505 B 505 B
withRouter.html gzip 485 B 485 B
Overall change 1.48 kB 1.48 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js shu/d9uz Change
edge-ssr.js gzip 110 kB 110 kB
page.js gzip 98.4 kB 98.4 kB
Overall change 209 kB 209 kB
Middleware size
vercel/next.js canary vercel/next.js shu/d9uz Change
middleware-b..fest.js gzip 584 B 584 B
middleware-r..fest.js gzip 145 B 145 B
middleware.js gzip 27 kB 27 kB
edge-runtime..pack.js gzip 1.83 kB 1.83 kB
Overall change 29.6 kB 29.6 kB
Commit: 9a505bd

@kodiakhq kodiakhq bot deleted the shu/d9uz branch December 23, 2022 19:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants