Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(docs): note cache-control header for preview/draft mode #53825

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 9, 2023

You can technically get similar ISR behavior setting the Cache-Control in getServerSideProps(), but this won't be automatically bypassed when enabling Preview Mode or Draft Mode so this PR adds that to the documentation.

x-ref: slack discussion

@styfle styfle requested review from a team as code owners August 9, 2023 21:59
@styfle styfle requested review from manovotny and StephDietz August 9, 2023 21:59
styfle and others added 2 commits August 10, 2023 09:42
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@styfle styfle requested review from delbaoliveira and ijjk August 10, 2023 13:42
@kodiakhq kodiakhq bot merged commit 2cf5d3a into canary Aug 10, 2023
@kodiakhq kodiakhq bot deleted the fix-docs-getserversideprops-draft-mode branch August 10, 2023 14:05
@drichfield
Copy link

You can technically get similar ISR behavior setting the Cache-Control in getServerSideProps(), but this won't be automatically bypassed when enabling Preview Mode or Draft Mode so this PR adds that to the documentation.

This is helpful context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants