Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(CI): improve datadog reporting #58267

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore(CI): improve datadog reporting #58267

merged 2 commits into from
Nov 23, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Nov 9, 2023 •
edited
Loading

Why?

  • test results should be reported to datadog even if one run failed
  • the workflows for reporting were confusing

Closes PACK-1927

@ijjk ijjk added area: tests created-by: Turbopack team PRs by the Turbopack team. and removed area: tests created-by: Turbopack team PRs by the Turbopack team. labels Nov 9, 2023
@ijjk
Copy link
Member

ijjk commented Nov 9, 2023 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
buildDuration 10.2s 10s N/A
buildDurationCached 5.9s 5.9s N/A
nodeModulesSize 199 MB 199 MB ✓
nextStartRea..uration (ms) 423ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 100 kB 100 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB ✓
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B ✓
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.17 kB 3.17 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
index.html gzip 527 B 526 B N/A
link.html gzip 539 B 540 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
middleware-b..fest.js gzip 625 B 625 B ✓
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB ✓
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 27.4 kB 27.4 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/improve-datadog-reporting Change
app-page-exp...dev.js gzip 167 kB 167 kB ✓
app-page-exp..prod.js gzip 93.3 kB 93.3 kB ✓
app-page-tur..prod.js gzip 94 kB 94 kB ✓
app-page-tur..prod.js gzip 88.6 kB 88.6 kB ✓
app-page.run...dev.js gzip 137 kB 137 kB ✓
app-page.run..prod.js gzip 87.9 kB 87.9 kB ✓
app-route-ex...dev.js gzip 23.8 kB 23.8 kB ✓
app-route-ex..prod.js gzip 16.5 kB 16.5 kB ✓
app-route-tu..prod.js gzip 16.5 kB 16.5 kB ✓
app-route-tu..prod.js gzip 16 kB 16 kB ✓
app-route.ru...dev.js gzip 23.2 kB 23.2 kB ✓
app-route.ru..prod.js gzip 16 kB 16 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.8 kB 21.8 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.8 kB 21.8 kB ✓
server.runti..prod.js gzip 49.1 kB 49.1 kB ✓
Overall change 924 kB 924 kB ✓
Commit: a5b133b

@ijjk
Copy link
Member

ijjk commented Nov 9, 2023 •
edited
Loading

Tests Passed

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/improve-datadog-reporting branch from 3d65054 to 7dc905d Compare November 13, 2023 17:13
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/improve-datadog-reporting branch from 7dc905d to 73c7d69 Compare November 13, 2023 18:11
ForsakenHarmony
ForsakenHarmony commented Nov 13, 2023
View reviewed changes
.github/workflows/build_and_test.yml

if [ -d ./test/turbopack-test-junit-report ]; then
# Add a `test.type` tag to distinguish between turbopack and next.js runs
DD_ENV=ci npx @datadog/datadog-ci@2.23.1 junit upload --tags test.type:turbopack --service nextjs ./test/turbopack-test-junit-report
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to merge the reports before uploading?

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review November 13, 2023 18:45
@ForsakenHarmony ForsakenHarmony requested review from S3Prototype and StephDietz and removed request for a team November 13, 2023 18:45
@ForsakenHarmony ForsakenHarmony merged commit 8bdda74 into canary Nov 23, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/improve-datadog-reporting branch November 23, 2023 14:18
@ForsakenHarmony ForsakenHarmony mentioned this pull request Nov 27, 2023
Merged
timneutkens added a commit that referenced this pull request Dec 4, 2023
@ForsakenHarmony @timneutkens
ci: report daily turbo integration test results from this repo (#58965)
15215d4 
### What?

A follow up for #58267 and #58394.

We no longer need the git branch for history it's stored in datadog now
and we also decided that we no longer need slack reporting.


Closes PACK-2039

---------

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@github-actions github-actions bot added the locked label Dec 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

@S3Prototype S3Prototype Awaiting requested review from S3Prototype S3Prototype was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForsakenHarmony @ijjk @sokra