-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
make tests more stable #58765
make tests more stable #58765
Conversation
@@ -43,6 +43,8 @@ describe('jsconfig-path-reloading', () => { | |||
|
|||
if (addAfterStart) { | |||
await next.patchFile(tsConfigFile, tsConfigContent) | |||
// wait a bit for the file watcher to pick up the change | |||
await new Promise((resolve) => setTimeout(resolve, 200)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a check()
with a function to verify if it has been picked up instead of using a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I detect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw there's also a waitFor
util that shorthands this: https://github.com/vercel/next.js/blob/canary/test/lib/next-test-utils.ts#L558-L560
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
What?
We need to give them a bit time to pick up the tsconfig change.
Closes PACK-2019