Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: unify reset project script #58829

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Nov 23, 2023

We have identical resetProject code used in bench/vercel and our e2e workflow action -- this updates the resetProject script to side-effects free (hence removing the env var) and shared between bench & e2e

Closes NEXT-1731

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Nov 23, 2023
@ztanner
Copy link
Member Author

ztanner commented Nov 23, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ztanner ztanner changed the title unify reset project script ci: unify reset project script Nov 23, 2023
@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 23, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
buildDuration 11.1s 11.1s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 430ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
index.html gzip 528 B 526 B N/A
link.html gzip 539 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
middleware-b..fest.js gzip 627 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 26.7 kB 26.7 kB
Next Runtimes
vercel/next.js canary vercel/next.js 11-23-unify_reset_project_script Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.3 kB 93.3 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.6 kB 88.6 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 88 kB 88 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: 13f2296

@ztanner ztanner force-pushed the 11-23-unify_reset_project_script branch from 8425389 to 04bbae1 Compare November 23, 2023 15:08
@ztanner ztanner marked this pull request as ready for review November 23, 2023 15:09
@ztanner ztanner requested review from ismaelrumzan and lydiahallie and removed request for a team November 23, 2023 15:09
feedthejim
feedthejim previously approved these changes Nov 23, 2023
@ztanner
Copy link
Member Author

ztanner commented Nov 23, 2023

Merge activity

  • Nov 23, 12:40 PM: @ztanner started a stack merge that includes this pull request via Graphite.
  • Nov 23, 12:40 PM: @ztanner merged this pull request with Graphite.

@ztanner ztanner merged commit cbcd598 into canary Nov 23, 2023
@ztanner ztanner deleted the 11-23-unify_reset_project_script branch November 23, 2023 17:40
@github-actions github-actions bot added the locked label Dec 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants