Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rewrites): support external rewrite destination #64943

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 23, 2024

What

Mimic original manifest generation to support external urls in rewrite config correctly.

@kwonoj kwonoj force-pushed the fix-rewrite-external branch from 236aefe to d1e18c1 Compare April 23, 2024 20:32
@ijjk
Copy link
Member

ijjk commented Apr 23, 2024

Tests Passed

@kwonoj kwonoj marked this pull request as ready for review April 23, 2024 20:46
@sokra sokra merged commit 05b5104 into canary Apr 23, 2024
74 of 80 checks passed
@sokra sokra deleted the fix-rewrite-external branch April 23, 2024 20:52
@github-actions github-actions bot added the locked label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants