Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix isTurbopack check in test cases #65446

Merged
merged 3 commits into from
May 7, 2024
Merged

fix isTurbopack check in test cases #65446

merged 3 commits into from
May 7, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented May 7, 2024

What?

Fix the isTurbopack flag in production test cases

@ijjk
Copy link
Member

ijjk commented May 7, 2024

Failing test suites

Commit: eabf7e4

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/next-test/next-test.test.ts (PPR)

  • next test > should execute playwright tests
Expand output

● next test › should execute playwright tests

expect(received).toContain(expected) // indexOf

Expected substring: "1 passed"
Received string:    "
Running 1 test using 1 worker·
  ✘  1 [chromium] › app/page.spec.js:3:1 › home page (23ms)··
  1) [chromium] › app/page.spec.js:3:1 › home page ─────────────────────────────────────────────────·
    Error: browserType.launch: Executable doesn't exist at /root/.cache/ms-playwright/chromium-1112/chrome-linux/chrome
    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browsers:              ║
    ║                                                                         ║
    ║     pnpm exec playwright install                                        ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝·
  1 failed
    [chromium] › app/page.spec.js:3:1 › home page ──────────────────────────────────────────────────·
To open last HTML report run:·
  pnpm exec playwright show-report·
"

  102 |     })
  103 |
> 104 |     expect(stdout).toContain('1 passed')
      |                    ^
  105 |   })
  106 |
  107 |   describe('test runner validation', () => {

  at Object.toContain (e2e/next-test/next-test.test.ts:104:20)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 7, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
buildDuration 17.5s 14.9s N/A
buildDurationCached 9s 1m 6.8s ⚠️ +57.8s
nodeModulesSize 360 MB 360 MB
nextStartRea..uration (ms) 428ms 427ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 230 B 229 B N/A
main-HASH.js gzip 31.6 kB 31.6 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 50.4 kB 50.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 8.27 kB 8.27 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
index.html gzip 527 B 527 B
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
edge-ssr.js gzip 94.9 kB 94.9 kB N/A
page.js gzip 182 kB 182 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
middleware-b..fest.js gzip 622 B 623 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.6 kB 94.6 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.3 kB 93.3 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.4 kB 21.4 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.8 kB 51.8 kB
Overall change 964 kB 964 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-is-turbopack Change
0.pack gzip 1.62 MB 1.62 MB ⚠️ +2.37 kB
index.pack gzip 114 kB 113 kB N/A
Overall change 1.62 MB 1.62 MB ⚠️ +2.37 kB
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 0549668

@sokra sokra enabled auto-merge (squash) May 7, 2024 14:59
@huozhi huozhi disabled auto-merge May 7, 2024 15:38
@huozhi huozhi merged commit 5a76ac9 into canary May 7, 2024
73 of 80 checks passed
@huozhi huozhi deleted the sokra/fix-is-turbopack branch May 7, 2024 15:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants