add effect packages into the optimized-by-default list #65465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @huozhi: |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
datner
force-pushed
the
patch-2
branch
3 times, most recently
from
233824e to
d1bfe01
Compare
|
How can I progress this? It's not a big complicated change.. |
|
please |
ijjk
approved these changes
May 16, 2024
shuding
approved these changes
May 16, 2024
|
Thank you ❤️ 🙏🏻 |
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
### What?
Adding packages from the Effect ecosystem to the list of
optimized-by-default imports
### Why?
Effect usage includes very liberal use of `import * as Module from
"effect/Module"` and `import { Module } from "effect"`. This is usually
trees-shaken but in nextjs we must declare it to be optimized to be have
this way. To provide a better experience to users I added all the
packages in the ecosystem to the list that are possibly relevant. I
don't expect all of them to get in, but the proposal should start from
the full set of possible candidates. Not included are `/cli`,
`/printer`, `/printer-ansi`, and `/vitest`.
At the very least `effect` and `/schema` should be added for their
prevalence, but even if there is hesitance I recommend adding
`/platform` and `/platform-node` since it's natural for effect usage to
grow into benefitting from these quickly enough.
Related issue in the effect repo
Effect-TS/effect#2701
cited source for taken action:
[the vercel
blog](https://vercel.com/blog/how-we-optimized-package-imports-in-next-js)
### How?
Adding strings to a set
Co-authored-by: JJ Kasper <jj@jjsweb.site>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding packages from the Effect ecosystem to the list of optimized-by-default imports
Why?
Effect usage includes very liberal use of
import * as Module from "effect/Module"andimport { Module } from "effect". This is usually trees-shaken but in nextjs we must declare it to be optimized to be have this way. To provide a better experience to users I added all the packages in the ecosystem to the list that are possibly relevant. I don't expect all of them to get in, but the proposal should start from the full set of possible candidates. Not included are/cli,/printer,/printer-ansi, and/vitest.At the very least
effectand/schemashould be added for their prevalence, but even if there is hesitance I recommend adding/platformand/platform-nodesince it's natural for effect usage to grow into benefitting from these quickly enough.Related issue in the effect repo
Effect-TS/effect#2701
cited source for taken action:
the vercel blog
How?
Adding strings to a set