Update Sanity example deps and prepare for next v15 #66158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
requested review from
timeyoutakeit and
leerob
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been testing React v19 and we're mostly ready. Since we have a number of upstream packages we have to update peer deps from:
{ "peerDependencies": { "react": "^18.3", "react-dom": "^18.3" } }to:
{ "peerDependencies": { "react": "^18.3 || ^19", "react-dom": "^18.3 || ^19" } }We are choosing to change the
nextsemver fromlatestto^14.2.3.This is to avoid the template from breaking after v15 becomes
latest, since package manager default behaviour doesn't handle conflicting peer dep ranges for react very well 🙌