Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix benchmark script #66789

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix benchmark script #66789

merged 3 commits into from
Jun 17, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 12, 2024

What?

  • fix CLI output regex for updates text
  • bench all scenarios
  • bench correct folder
  • make an real change instead of only a comment

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. tests labels Jun 12, 2024
@timneutkens timneutkens merged commit 50c7e93 into canary Jun 17, 2024
33 checks passed
@timneutkens timneutkens deleted the sokra/fix-bench branch June 17, 2024 11:10
@github-actions github-actions bot added the locked label Jul 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @timneutkens @ijjk