Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: update code block filename in dynamic API context error page #67000

Merged
merged 3 commits into from
Jun 19, 2024
Merged

docs: update code block filename in dynamic API context error page #67000

merged 3 commits into from
Jun 19, 2024

Conversation

Juneezee
Copy link
Contributor

The filenames of the two code blocks on this page https://nextjs.org/docs/messages/next-dynamic-api-wrong-context are written as comment instead of using the filename prop.

image

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested review from a team as code owners June 18, 2024 16:29
@Juneezee Juneezee requested review from jh3y and timeyoutakeit and removed request for a team June 18, 2024 16:29
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 18, 2024
@ijjk
Copy link
Member

ijjk commented Jun 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9aadd0c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jun 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 9aadd0c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) June 19, 2024 10:18
@samcx samcx merged commit 445cc62 into vercel:canary Jun 19, 2024
33 checks passed
@github-actions github-actions bot added the locked label Jul 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants