Skip to content

with-mongodb update to add both App and Pages Router examples #68461

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 15 commits into from
Aug 2, 2024
Merged

with-mongodb update to add both App and Pages Router examples #68461

merged 15 commits into from
Aug 2, 2024

Conversation

codeSTACKr
Copy link
Contributor

Updated all dependencies and added an app route to demonstrate both pages an app directories.

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 2, 2024
@ijjk
Copy link
Member

ijjk commented Aug 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7332245

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review August 2, 2024 19:50
@samcx samcx added the CI approved Approve running CI for fork label Aug 2, 2024
@samcx samcx removed the CI approved Approve running CI for fork label Aug 2, 2024
@samcx
Copy link
Member

samcx commented Aug 2, 2024

@codeSTACKr ok I see what's up, the check-examples lint check is affecting examples/with-mongodb/next-env.d.ts (removes a reference type)

@samcx
Copy link
Member

samcx commented Aug 2, 2024

@codeSTACKr I'll fix the check-examples script in a separate PR! For now, we'll just commit without one of the reference types, which automatically fixes itself anyways when you run the example with next dev.

@samcx samcx merged commit f33097c into vercel:canary Aug 2, 2024
35 checks passed
@codeSTACKr
Copy link
Contributor Author

@samcx thank you!

@codeSTACKr codeSTACKr deleted the with-mongodb-update branch August 3, 2024 15:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants