Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

codemod: fix merging react imports logic #70706

Merged
merged 1 commit into from
Oct 2, 2024
Merged

codemod: fix merging react imports logic #70706

merged 1 commit into from
Oct 2, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 2, 2024 •
edited
Loading

Remove the Literal restriction which lead to the miss of searching "react" import

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 2, 2024
@huozhi Graphite App
Copy link
Member Author

huozhi commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @huozhi and the rest of your teammates on Graphite Graphite

@huozhi huozhi marked this pull request as ready for review October 2, 2024 13:20
@ijjk
Copy link
Member

ijjk commented Oct 2, 2024 •
edited
Loading

Tests Passed

@huozhi huozhi requested a review from eps1lon October 2, 2024 13:35
@huozhi huozhi merged commit 39e06c7 into canary Oct 2, 2024
103 of 108 checks passed
@huozhi huozhi deleted the 10-02-codemod_improve_duplicate_insert_react branch October 2, 2024 13:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @eps1lon