Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

codemod: polish end message #71259

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 14, 2024

What

highlight the end message, and make sure we always log them even in early return

A case of early return message
image.png

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 14, 2024
Copy link
Member Author

huozhi commented Oct 14, 2024

@ijjk
Copy link
Member

ijjk commented Oct 14, 2024

Failing test suites

Commit: 39d9c61

TURBOPACK=1 pnpm test-dev test/development/app-hmr/hmr.test.ts (turbopack)

  • app-dir-hmr > filesystem changes > should update server components pages when env files is changed (node)
Expand output

● app-dir-hmr › filesystem changes › should update server components pages when env files is changed (node)

expect(received).toBe(expected) // Object.is equality

Expected: "mac"
Received: "ipad"

  145 |       async (page) => {
  146 |         const browser = await next.browser(`/env/${page}`)
> 147 |         expect(await browser.elementByCss('p').text()).toBe('mac')
      |                                                        ^
  148 |         await next.patchFile(envFile, 'MY_DEVICE="ipad"')
  149 |
  150 |         const logs = await browser.log()

  at toBe (development/app-hmr/hmr.test.ts:147:56)

Read more about building and testing Next.js in contributing.md.

Base automatically changed from 10-14-codemod_install_types_as_dev_deps to canary October 14, 2024 13:30
An error occurred while trying to automatically change base from 10-14-codemod_install_types_as_dev_deps to canary October 14, 2024 13:30
@huozhi huozhi force-pushed the 10-14-codemod_polish_the_final_log branch from 39d9c61 to 5f229fc Compare October 14, 2024 13:33
@huozhi huozhi merged commit b30ae4e into canary Oct 14, 2024
91 of 98 checks passed
@huozhi huozhi deleted the 10-14-codemod_polish_the_final_log branch October 14, 2024 13:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants