fix: make "Release stats" use the correct artifact name #71323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no artifact called
next-swc-binaries, all the other places usenext-swc-binaries-*The name's coming from here:
next.js/.github/workflows/build_and_deploy.yml
Line 377 in bc30936
Example failing run: https://github.com/vercel/next.js/actions/runs/11352776677/job/31576710878
It's failing because
download-artifactdidn't download anything (because of the incorrect name), and thenativedirectory no longer exists (it used to have a .gitkeep inside, but we removed that a while ago), so it just crashes