examples: Add .npmrc to Dockerfile to support custom npm configs #72132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
approved these changes
Nov 1, 2024
stipsan
pushed a commit
to sanity-io/next.js
that referenced
this pull request
Nov 6, 2024
…cel#72132) ### Description: This PR continues the work started in [vercel#72064](vercel#72064) (already merged) by updating the Dockerfiles in the `examples` folder to include the `.npmrc` file in the dependency copy command. ### Original Command: ```dockerfile # Install dependencies based on the preferred package manager COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* ./ ``` ### Updated Command: ```dockerfile # Install dependencies based on the preferred package manager COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* .npmrc* ./ ``` ### Reason for Change: Including `.npmrc` allows for custom npm configurations, such as `legacy-peer-deps=true`. Without this option, some installations can fail due to unresolved peer dependencies, particularly for projects with older dependencies. This update ensures that any additional configurations specified in `.npmrc` are applied during installation, improving Docker build consistency and stability for projects with custom npm requirements. ### Diff: ```diff - COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* ./ + COPY package.json yarn.lock* package-lock.json* pnpm-lock.yaml* .npmrc* ./ ```
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR continues the work started in #72064 (already merged) by updating the Dockerfiles in the
examplesfolder to include the.npmrcfile in the dependency copy command.Original Command:
Updated Command:
Reason for Change:
Including
.npmrcallows for custom npm configurations, such aslegacy-peer-deps=true. Without this option, some installations can fail due to unresolved peer dependencies, particularly for projects with older dependencies.This update ensures that any additional configurations specified in
.npmrcare applied during installation, improving Docker build consistency and stability for projects with custom npm requirements.Diff: