Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dynamicIO] use new heuristic to track whether server render is dynamic #73751

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

gnoff
Copy link
Contributor

@gnoff gnoff commented Dec 10, 2024

Instead of relying on onError just use the timing of the prerender resolution to determine whether the server render completed before aborting.

React is going to remove onError and onPostpone calls from prerender in flight 31715. This is because semantically the error is going to be hidden from the prerender and on resume it might not error. So rather than relying on whether the error callback is called we simply infer whether we are done by checking if the prerender resolved prior to our abort deadline. In our case it is possible we also aborted earlier than the deadline because you can call something like Math.random() which requires the prerender to halt synchronously so we also check the signal status in our deadline task.

We don't expect this to change any semantics so there are no altered tests.

This is only currently implemented in the dynamicIO + PPR case because that is the only case using experimental React with prerender. When dynamicIO is on by itself we still use renderToReadableStream which does not have halt semantics. We will switch to prerender when it is available in React's stable channel

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 10, 2024
@gnoff gnoff requested a review from sebmarkbage December 10, 2024 17:44
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Tests Passed

@gnoff gnoff requested a review from eps1lon December 10, 2024 17:45
Instead of relying on onError just use the timing of the prerender resolution to determine whether the server render completed before aborting.
@gnoff gnoff force-pushed the dio-refactor-server-dynamic branch from b343b78 to 2f10a12 Compare December 10, 2024 18:02
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
buildDuration 18.9s 17.1s N/A
buildDurationCached 16s 13.6s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +23.4 kB
nextStartRea..uration (ms) 482ms 486ms N/A
Client Bundles (main, webpack)
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
index.html gzip 523 B 523 B
link.html gzip 537 B 538 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
middleware-b..fest.js gzip 669 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB N/A
app-page-exp..prod.js gzip 127 kB 127 kB N/A
app-page-tur..prod.js gzip 140 kB 140 kB N/A
app-page-tur..prod.js gzip 135 kB 135 kB N/A
app-page.run...dev.js gzip 312 kB 312 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB N/A
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.19 MB 1.19 MB
build cache Overall increase ⚠️
vercel/next.js canary gnoff/next.js dio-refactor-server-dynamic Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +2.9 kB
index.pack gzip 71.7 kB 71.7 kB N/A
Overall change 2.04 MB 2.04 MB ⚠️ +2.9 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 2f10a12

@gnoff gnoff merged commit f8b3174 into vercel:canary Dec 10, 2024
86 checks passed
@gnoff gnoff deleted the dio-refactor-server-dynamic branch December 10, 2024 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants