Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

examples: update with-mdx-remote example to utilize the App Router #74067

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

JamBalaya56562
Copy link
Contributor

Description

This PR updates the with-mdx-remote example to use the App Router and TypeScript. Here are the changes that have been made:

  1. Renamed the pages folder to the app folder.
  2. Converted JavaScript to TypeScript files and created tsconfig.json.
  3. Created a new global.css and layout.tsx files in the app directory.
  4. Used CSS module instead of styled-jsx.
  5. Removed next-remote-watch due to incompatibility and no maintenance.
  6. Removed gray-matter and implement front-matter parser as well.
  7. Updated the .gitignore, package.json and README.md files.

The new app looks and works much the same as the old one.

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 18, 2024
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 872d222

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/next-mdx-remote@5.0.0 environment +36 1.17 MB hashibot-web

🚮 Removed packages: npm/next-mdx-remote@3.0.8, npm/next-remote-watch@1.0.0

View full report↗︎

@samcx samcx self-requested a review December 18, 2024 17:28
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) December 18, 2024 18:11
@samcx samcx merged commit 9332370 into vercel:canary Dec 18, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the mdx-remote branch December 18, 2024 23:37
@github-actions github-actions bot added the locked label Jan 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants