chore(examples): updated the example of with-styled-components-rtl to utlize the App router #74180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… utlize the App router
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
@Manoj-M-S We should remove the example as the dependency has not been updated in a while. |
samcx
approved these changes
Jan 7, 2025
wbinnssmith
pushed a commit
that referenced
this pull request
Jan 10, 2025
… utlize the App router (#74180) This PR updates the with-styled-components-rtl example to use the App Router. Here are the changes that have been made: - Renamed the `pages` folder to the `app` folder. - Converted the `index.tsx` to `page.tsx` file as part of the App Router. - Created `layout.tsx` in app directory, merging functionality from both ` _app.tsx` and `_document.tsx`: - `ThemeProvider` setup from `_app.tsx` - `RTL` and `styled-components` setup from `_document.tsx` - Created `lib/registry.tsx` for styled-components server-side rendering and moved styled-components server-side rendering logic from `_document.tsx` - Updated the package.json file. The following actions were performed as part of this PR: - Ran `pnpm prettier-check` with no issues found. - Executed the `pnpm check-examples` script. CC: @samcx --------- Co-authored-by: samcx <sam@vercel.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the with-styled-components-rtl example to use the App Router. Here are the changes that have been made:
pagesfolder to theappfolder.index.tsxtopage.tsxfile as part of the App Router.layout.tsxin app directory, merging functionality from both_app.tsxand_document.tsx:ThemeProvidersetup from_app.tsxRTLandstyled-componentssetup from_document.tsxlib/registry.tsxfor styled-components server-side rendering and moved styled-components server-side rendering logic from_document.tsxThe following actions were performed as part of this PR:
pnpm prettier-checkwith no issues found.pnpm check-examplesscript.CC: @samcx