Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DevOverlay] fix: restore pagination style #74296

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 25, 2024

Why?

This PR restores the pagination style, which was accidentally omitted at #74097.

Before

Screenshot 2024-12-25 at 8.37.33 PM.png

After

Screenshot 2024-12-25 at 8.37.07 PM.png

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 25, 2024 11:38
@devjiwonchoi devjiwonchoi force-pushed the 12-25-_devoverlay_fix_restore_pagination_style branch from eb5a662 to a31b1e3 Compare December 25, 2024 11:42
@ijjk
Copy link
Member

ijjk commented Dec 25, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
buildDuration 19s 15.9s N/A
buildDurationCached 15s 12.8s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +37.9 kB
nextStartRea..uration (ms) 472ms 485ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
middleware-b..fest.js gzip 670 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB ⚠️ +305 B
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 347 kB 348 kB ⚠️ +299 B
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB ⚠️ +604 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-25-_devoverlay_fix_restore_pagination_style Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +6.42 kB
index.pack gzip 75.1 kB 74.9 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +6.42 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: a31b1e3

@devjiwonchoi devjiwonchoi merged commit 26f6133 into canary Dec 25, 2024
130 checks passed
@devjiwonchoi devjiwonchoi deleted the 12-25-_devoverlay_fix_restore_pagination_style branch December 25, 2024 13:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants