Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add prerender abort errors to unstable rethrow #74556

Merged

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Jan 6, 2025

Prerender errors triggered during development should be rethrown by the unstable_rethrow api.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 6, 2025
@wyattjoh wyattjoh marked this pull request as ready for review January 6, 2025 16:16
Copy link
Member Author

wyattjoh commented Jan 6, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
buildDuration 35.9s 33.1s N/A
buildDurationCached 33.4s 29.3s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +17.2 kB
nextStartRea..uration (ms) 787ms 848ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
index.html gzip 523 B 523 B
link.html gzip 538 B 535 B N/A
withRouter.html gzip 519 B 519 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
middleware-b..fest.js gzip 669 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 363 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 352 kB 352 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.4 kB 25.4 kB N/A
app-route.ru...dev.js gzip 39.2 kB 39.2 kB N/A
app-route.ru..prod.js gzip 25.4 kB 25.4 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.55 MB 1.55 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow Change
0.pack gzip 2.09 MB 2.08 MB N/A
index.pack gzip 73.9 kB 74 kB ⚠️ +157 B
Overall change 73.9 kB 74 kB ⚠️ +157 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 94b7763

@wyattjoh wyattjoh merged commit 2285465 into canary Jan 7, 2025
130 checks passed
@wyattjoh wyattjoh deleted the 01-06-fix_add_prerender_abort_errors_to_unstable_rethrow branch January 7, 2025 18:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants