Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(ci): Ensure all 6 shards are used equally in deploy tests #74574

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented Jan 7, 2025

No description provided.

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Allow CI Workflow Run

  • approve CI run for commit: cf96eca

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@eps1lon eps1lon requested a review from ztanner January 7, 2025 09:15
@@ -46,7 +46,7 @@ jobs:
strategy:
fail-fast: false
matrix:
group: [1/5, 2/5, 3/5, 4/5, 5/5, 6/6]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we just ran the last 1/6th of the test twice this way? Don't think that was intentional, thank you!

Copy link
Contributor Author

@nnnnoel nnnnoel Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the history of this line, matrix group was 6 first and reduced to 5, and manually rolled back to 6 lol

@eps1lon eps1lon changed the title chore(ci): matrix group typo chore(ci): Ensure all 6 shards are used equally in deploy tests Jan 7, 2025
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
buildDuration 51.5s 46.2s N/A
buildDurationCached 43.6s 32.6s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 910ms 888ms N/A
Client Bundles (main, webpack)
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
index.html gzip 524 B 522 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 363 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 352 kB 352 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.45 MB 2.45 MB
build cache Overall increase ⚠️
vercel/next.js canary nnnnoel/next.js ci/typo-matrix-group Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.5 kB 75.3 kB ⚠️ +723 B
Overall change 74.5 kB 75.3 kB ⚠️ +723 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: cf96eca

@eps1lon eps1lon merged commit 450a04f into vercel:canary Jan 7, 2025
123 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants