Always display version indicator #74774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztanner
approved these changes
Jan 10, 2025
| @@ -631,9 +631,7 @@ export async function createHotReloaderTurbopack( | |||
| getNextErrorFeedbackMiddleware(opts.telemetry), | |||
| ] | |||
|
|
|||
| const versionInfoPromise = getVersionInfo( | |||
| isTestMode || opts.telemetry.isEnabled | |||
There was a problem hiding this comment.
wondering if we had this disabled in test mode due to network flakes? but lgtm if it isn't causing problems.
There was a problem hiding this comment.
Maybe we should just move these checks lower. The installed version should always be displayed but whether we check for latest/canary should continue to be tied to telemetry settings.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the condition to check when version indicator can be displayed as it doesn't have to be coupled with test mode or telemetry