Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gate captureOwnerStack access on experimental.reactOwnerStack #75241

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 23, 2025

The conditional access was only needed while we have the flag. So we might as well just gate it behind the flag so that we automatically clean it up when we remove the flag.

Since these modules are dev-only we'll never need the conditional access once the flag is on.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 23, 2025
Copy link
Member Author

eps1lon commented Jan 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from cd46108 to c1f33f9 Compare January 23, 2025 20:24
@eps1lon eps1lon changed the base branch from canary to sebbie/react-types-bump January 23, 2025 20:25
@eps1lon eps1lon mentioned this pull request Jan 23, 2025
@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
buildDuration 23.9s 20.4s N/A
buildDurationCached 19.5s 16.4s N/A
nodeModulesSize 392 MB 392 MB N/A
nextStartRea..uration (ms) 557ms 535ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
5306-HASH.js gzip 54.1 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 519 B 519 B
Overall change 519 B 519 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
middleware-b..fest.js gzip 669 B 664 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
app-page-exp...dev.js gzip 386 kB 386 kB N/A
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page.run...dev.js gzip 373 kB 373 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB
pages-api.ru...dev.js gzip 11.5 kB 11.5 kB
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB
pages-turbo...prod.js gzip 21.6 kB 21.6 kB
pages.runtim...dev.js gzip 31.3 kB 31.3 kB
pages.runtim..prod.js gzip 21.6 kB 21.6 kB
server.runti..prod.js gzip 73.7 kB 73.7 kB
Overall change 901 kB 901 kB
build cache
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.8 kB 75.5 kB N/A
Overall change 0 B 0 B
Diff details
Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for pages.runtime.dev.js

Diff too large to display

Commit: 02811ba

@eps1lon eps1lon force-pushed the sebbie/react-types-bump branch from f581d82 to 78c7f4e Compare January 23, 2025 20:37
@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from c1f33f9 to ec8bd6b Compare January 23, 2025 20:37
@eps1lon eps1lon force-pushed the sebbie/react-types-bump branch from 78c7f4e to d7953ad Compare January 24, 2025 09:28
@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from ec8bd6b to 42aa9a8 Compare January 24, 2025 09:28
@eps1lon eps1lon marked this pull request as ready for review January 24, 2025 09:30
@eps1lon eps1lon requested a review from huozhi January 24, 2025 09:31
@ijjk
Copy link
Member

ijjk commented Jan 24, 2025

Tests Passed

@eps1lon eps1lon force-pushed the sebbie/react-types-bump branch from d7953ad to 74d679d Compare January 24, 2025 11:30
@eps1lon eps1lon changed the base branch from sebbie/react-types-bump to graphite-base/75241 January 24, 2025 11:46
Copy link

graphite-app bot commented Jan 24, 2025

Merge activity

  • Jan 24, 12:47 PM GMT+1: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@eps1lon eps1lon force-pushed the graphite-base/75241 branch from 74d679d to 8ee79b8 Compare January 24, 2025 18:38
@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from 42aa9a8 to 796e5c5 Compare January 24, 2025 18:38
@eps1lon eps1lon changed the base branch from graphite-base/75241 to canary January 24, 2025 18:38
@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from 796e5c5 to 02811ba Compare January 28, 2025 09:44
@eps1lon eps1lon merged commit f98faf5 into canary Jan 28, 2025
131 checks passed
@eps1lon eps1lon deleted the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch January 28, 2025 10:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants