-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[DevOverlay] Remove unused props from errors.tsx
and its story
#75392
Merged
devjiwonchoi
merged 2 commits into
canary
from
01-28-_devoverlay_fix_regression_on_errors.tsx_story
Jan 28, 2025
Merged
[DevOverlay] Remove unused props from errors.tsx
and its story
#75392
devjiwonchoi
merged 2 commits into
canary
from
01-28-_devoverlay_fix_regression_on_errors.tsx_story
Jan 28, 2025
+122
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
errors
value from errors.tsx
and its story
errors
value from errors.tsx
and its storyerrors.tsx
and its story
Tests Passed |
37e8e06
to
7fafd4f
Compare
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
buildDuration | 20.1s | 16.5s | N/A |
buildDurationCached | 15.6s | 12.9s | N/A |
nodeModulesSize | 392 MB | 392 MB | N/A |
nextStartRea..uration (ms) | 446ms | 442ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
5306-HASH.js gzip | 54 kB | 53.9 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.5 kB | 34.4 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 52.9 kB | 52.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 537 B | 538 B | N/A |
withRouter.html gzip | 518 B | 519 B | N/A |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 210 kB | 210 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 670 B | 664 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 386 kB | 386 kB | N/A |
app-page-exp..prod.js gzip | 131 kB | 131 kB | ✓ |
app-page-tur..prod.js gzip | 144 kB | 144 kB | ✓ |
app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
app-page.run...dev.js gzip | 373 kB | 373 kB | N/A |
app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
app-route-ex...dev.js gzip | 39.4 kB | 39.4 kB | ✓ |
app-route-ex..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
app-route.ru...dev.js gzip | 41 kB | 41 kB | ✓ |
app-route.ru..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
pages-api-tu..prod.js gzip | 8.81 kB | 8.81 kB | ✓ |
pages-api.ru...dev.js gzip | 11.5 kB | 11.5 kB | ✓ |
pages-api.ru..prod.js gzip | 8.8 kB | 8.8 kB | ✓ |
pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
pages.runtim...dev.js gzip | 31.3 kB | 31.3 kB | ✓ |
pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
server.runti..prod.js gzip | 73.7 kB | 73.7 kB | ✓ |
Overall change | 901 kB | 901 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-28-_devoverlay_fix_regression_on_errors.tsx_story | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.1 MB | N/A |
index.pack gzip | 74.9 kB | 75.1 kB | |
Overall change | 74.9 kB | 75.1 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
raunofreiberg
approved these changes
Jan 28, 2025
There was no story for having CodeFrame & CallStack. Therefore added to the default error story.
Merge activity
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
While decoupling the error overlay with the indicator at #74999, we lifted up calculating the
readyErrors
to the parent component. Therefore, passing theerrors
value to theerror.tsx
component is unnecessary.How?
Removed the unused
errors
andhasStaticIndicator
props fromerrors.tsx
and its story.