Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dev-overlay] add a11y test #75523

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 31, 2025

Added a11y test, but haven't enabled for the CI. Will follow up to resolve the test result.

CleanShot 2025-02-01 at 03 20 54

You can manually test a11y at the storybook portal:

CleanShot.2025-02-01.at.03.23.30.mp4

Closes https://linear.app/vercel/issue/NDX-584/add-a11y-tests

Copy link
Member Author

devjiwonchoi commented Jan 31, 2025

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 31, 2025 18:24
@devjiwonchoi devjiwonchoi force-pushed the 02-01-_dev-overlay_bump_storybook_to_8.5.2 branch from 24ced7e to 66826fc Compare January 31, 2025 19:26
@devjiwonchoi devjiwonchoi force-pushed the 02-01-_dev-overlay_add_a11y_test branch from 4654480 to 577f1c1 Compare January 31, 2025 19:26
Base automatically changed from 02-01-_dev-overlay_bump_storybook_to_8.5.2 to canary January 31, 2025 19:26
@devjiwonchoi devjiwonchoi force-pushed the 02-01-_dev-overlay_add_a11y_test branch from 577f1c1 to 5b62b8c Compare January 31, 2025 19:27
@devjiwonchoi devjiwonchoi merged commit dbce745 into canary Jan 31, 2025
11 of 21 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-01-_dev-overlay_add_a11y_test branch January 31, 2025 19:28
Copy link

@hamidshirzad hamidshirzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overnight

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants