-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[dev-overlay] add a11y test #75523
Merged
Merged
[dev-overlay] add a11y test #75523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gaojude
approved these changes
Jan 31, 2025
24ced7e
to
66826fc
Compare
4654480
to
577f1c1
Compare
Base automatically changed from
02-01-_dev-overlay_bump_storybook_to_8.5.2
to
canary
January 31, 2025 19:26
577f1c1
to
5b62b8c
Compare
hamidshirzad
reviewed
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overnight
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a11y test, but haven't enabled for the CI. Will follow up to resolve the test result.
You can manually test a11y at the storybook portal:
CleanShot.2025-02-01.at.03.23.30.mp4
Closes https://linear.app/vercel/issue/NDX-584/add-a11y-tests