[Turbopack] await shutdown before ending pool #75545
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
changed the title
sokra
force-pushed
the
sokra/correctly-stop-turbopack
branch
from
9727c73 to
62498d5
Compare
Tests Passed |
sokra
force-pushed
the
sokra/correctly-stop-turbopack
branch
from
62498d5 to
5fa05bf
Compare
mischnic
approved these changes
Feb 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure to gracefully shutdown the Turbopack process, by waiting for shutdown before killing the process.
This makes sure Persistent Caching will have time to store the cache, before it's killed. That should happen in background while doing SSG. (Maybe we need to change that in future for memory reasons, but it will work for now.)
Closes PACK-3887