Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean-up: remove unused errorMessage param in stack frames #75554

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Feb 1, 2025

errorMessage is passed to endpoint but never actually used, so thought it was safe to delete. This also simplifies request batching.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 1, 2025
Copy link
Contributor Author

gaojude commented Feb 1, 2025

@gaojude gaojude changed the title error msg is unused fix: remove unused error message param in stack frames Feb 1, 2025
@gaojude gaojude marked this pull request as ready for review February 1, 2025 13:56
@gaojude gaojude force-pushed the 02-01-error_msg_is_unused branch from 6c81215 to 4d61b5a Compare February 1, 2025 14:02
@gaojude gaojude force-pushed the extract-api-core-webpack branch from 2f76260 to a0c2124 Compare February 3, 2025 16:41
@gaojude gaojude force-pushed the 02-01-error_msg_is_unused branch from 4d61b5a to 0a94da9 Compare February 3, 2025 16:42
@gaojude gaojude force-pushed the extract-api-core-webpack branch from a0c2124 to 539bacf Compare February 3, 2025 16:55
@gaojude gaojude force-pushed the 02-01-error_msg_is_unused branch from 0a94da9 to 8749ab9 Compare February 3, 2025 16:55
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
buildDuration 18.4s 17.1s N/A
buildDurationCached 16s 13.4s N/A
nodeModulesSize 391 MB 391 MB N/A
nextStartRea..uration (ms) 445ms 451ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
middleware-b..fest.js gzip 670 B 663 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
app-page-exp...dev.js gzip 385 kB 385 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 895 kB 895 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-01-error_msg_is_unused Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +2.3 kB
index.pack gzip 75.8 kB 75.4 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +2.3 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: c429f09

@gaojude gaojude changed the title fix: remove unused error message param in stack frames remove unused error message param in stack frames Feb 3, 2025
@gaojude gaojude changed the title remove unused error message param in stack frames Clean-up: remove unused errorMessage param in stack frames Feb 3, 2025
Base automatically changed from extract-api-core-webpack to canary February 3, 2025 23:13
@gaojude gaojude closed this Feb 3, 2025
@gaojude gaojude reopened this Feb 3, 2025
@gaojude gaojude force-pushed the 02-01-error_msg_is_unused branch from 8749ab9 to c429f09 Compare February 3, 2025 23:41
@gaojude gaojude merged commit 1dfca62 into canary Feb 4, 2025
131 checks passed
@gaojude gaojude deleted the 02-01-error_msg_is_unused branch February 4, 2025 03:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants